[FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF

[Michael Niedermayer]

On Thu, Oct 01, 2020 at 03:29:19PM +0100, Harry Mallon wrote:
> 
> 
> 
> > On 30 Sep 2020, at 08:32, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > 
> > On Thu, Sep 17, 2020 at 10:49:31PM +0200, Tomas Härdin wrote:
> >> mån 2020-09-14 klockan 12:23 +0200 skrev Tomas Härdin:
> >>> ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon:
> >>>> * As embedded by Apple Compressor
> >>>> 
> >>>> Signed-off-by: Harry Mallon <harry.mallon at codex.online>
> >>>> ---
> >>>> libavformat/mxfdec.c                |  27 +++++
> >>>> tests/fate/mxf.mak                  |   4 +
> >>>> tests/ref/fate/mxf-probe-applehdr10 | 169
> >>>> ++++++++++++++++++++++++++++
> >>> 
> >>> Sweet, I don't have to write the test myself .)
> >>> 
> >>> Just ran FATE, the entire patch set works fine. We just need to get
> >>> that sample into the sample suite then all three of them can be
> >>> pushed.
> >>> I'll see what I can do.
> >> 
> >> FATE suite updated, FATE passes -> patchset pushed
> > 
> > fails on big endian
> > 
> > --- src/tests/ref/fate/mxf-probe-applehdr10	2020-09-28 23:21:12.291897976 +0200
> > +++ tests/data/fate/mxf-probe-applehdr10	2020-09-30 09:31:38.614653806 +0200
> > @@ -14,7 +14,7 @@
> > has_b_frames=0
> > sample_aspect_ratio=1:1
> > display_aspect_ratio=16:9
> > -pix_fmt=yuv422p10le
> > +pix_fmt=yuv422p10be
> > level=-99
> > color_range=tv
> > color_space=bt2020nc
> > Test mxf-probe-applehdr10 failed. Look at tests/data/fate/mxf-probe-applehdr10.err for details.
> > src/tests/Makefile:255: recipe for target 'fate-mxf-probe-applehdr10' failed
> > make: *** [fate-mxf-probe-applehdr10] Error 1
> 
> It seems fair that the pixel type is in native endian.

maybe but the endianness of the decoder output doesnt belong in the
comparission


> I'm not really familiar enough with FATE to provide a patch to fix this though. Do any other FATE tests have wildcards or two versions for big and little endian?

i dont see another probe reference file that contains a le/be format

we had le/be issues in other places though where they where fixed by forcing
a format with specific endianness in the test IIRC

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201001/8c290e97/attachment.sig>