[FFmpeg-devel] [PATCH 4/4] avcodec/mobiclip: Check mv against INT_MAX

Michael Niedermayer michael at niedermayer.cc
Sun Nov 15 00:26:28 EET 2020


Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
Fixes: 27369/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-5083469356728320

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/mobiclip.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/mobiclip.c b/libavcodec/mobiclip.c
index 9fa88e84a0..8504959b22 100644
--- a/libavcodec/mobiclip.c
+++ b/libavcodec/mobiclip.c
@@ -1146,6 +1146,8 @@ static int predict_motion(AVCodecContext *avctx,
             mv.x = mv.x + get_se_golomb(gb);
             mv.y = mv.y + get_se_golomb(gb);
         }
+        if (mv.x >= INT_MAX || mv.y >= INT_MAX)
+            return AVERROR_INVALIDDATA;
 
         motion[offsetm].x = mv.x;
         motion[offsetm].y = mv.y;
-- 
2.17.1



More information about the ffmpeg-devel mailing list