[FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: derive skip_mode_frame_idx only where it's used

James Almer jamrial at gmail.com
Sat Nov 14 17:08:30 EET 2020


On 11/14/2020 12:01 PM, Timo Rothenpieler wrote:
> I still strongly dislike this whole thing.
> The same logic is ran essentially twice.
> 
> But I also really don't like putting all this stuff into the hwaccel.
> That's way more logic than a hwaccel integration should have to do.

Atm, only nvdec cares about these fields, and since all reference 
AV1RawFrameHeader are now available in hwaccel->start_frame(), it seemed 
proper to have it there.

Eventually, a software implementation will be added to av1dec, and this 
code will have to be moved back. But if you are really against this set, 
then I'll withdraw it.


More information about the ffmpeg-devel mailing list