[FFmpeg-devel] [PATCH] fate: Convert the musepack8 test to an oneoff test

[Andreas Rheinhardt]

Martin Storsjö:
> This fixes tests if built for x86 with x87 FPU.
> ---
> This requires someone to upload a reference file.
> ---
>  tests/fate/mpc.mak | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/fate/mpc.mak b/tests/fate/mpc.mak
> index bb1c03d250..cde6e55177 100644
> --- a/tests/fate/mpc.mak
> +++ b/tests/fate/mpc.mak
> @@ -12,7 +12,9 @@ fate-musepack7: REF = $(SAMPLES)/musepack/inside-mp7.pcm
>  FATE_MPC-$(call ALLYES, FILE_PROTOCOL MPC8_DEMUXER MPC8_DECODER  \
>                          ARESAMPLE_FILTER PCM_S16LE_ENCODER  \
>                          FRAMECRC_MUXER PIPE_PROTOCOL) += fate-musepack8
> -fate-musepack8: CMD = framecrc -i $(TARGET_SAMPLES)/musepack/inside-mp8.mpc -ss 8.4 -af aresample -c:a pcm_s16le
> +fate-musepack8: CMD = pcm -i $(TARGET_SAMPLES)/musepack/inside-mp8.mpc -ss 8.4 -af aresample
> +fate-musepack8: CMP = oneoff
> +fate-musepack8: REF = $(SAMPLES)/musepack/inside-mp8.pcm
>  
>  FATE_SAMPLES_AVCONV += $(FATE_MPC-yes)
>  fate-mpc: $(FATE_MPC-yes)
> 
To quote myself:
"The test uses the framecrc output, because Musepack SV8 is an encoder
that returns multiple frames for a single packet, so that timing
information in the test output is valueable. Output seeking has been
used in order to limit the size of the ref file as well as to test this
codepath for the first time."
The timing information would be lost with your patch; output seeking
would only be implicitly tested (by looking at the first sample that is
retained). And of course your ref file would be way bigger. So is there
no better way?

- Andreas