[FFmpeg-devel] [PATCH] aviobuf: Increase the default SHORT_SEEK_THRESHOLD to 32 KB

[Martin Storsjö]

On Thu, 5 Nov 2020, Martin Storsjö wrote:

> The previous threshold, 4 KB, maybe was reasonable when it was set
> (in 2010), but in today's settings and with typical network speeds
> and data sizes, it's pretty small. 32 KB probably is a more reasonable
> default now, regardless of input.
>
> This changes the test references for two seek tests.
>
> When using the normal seek function, which boils down to the lseek(2)
> function, a seek to an out of bounds position doesn't return an error,
> but that condition is only reported when doing the subsequent read
> (which returns EOF). When doing more seeks by fast forwarding, the
> fact that the seeked to destination is out of bounds is noticed and
> reported sooner in these cases.
> ---
> Updated with new test references for tests that change, and analysis
> of the reason for the changed test references.
> ---
> libavformat/aviobuf.c  |  2 +-
> tests/ref/seek/lavf-al | 13 +++++--------
> tests/ref/seek/lavf-ul | 13 +++++--------
> 3 files changed, 11 insertions(+), 17 deletions(-)

As there hasn't been any comments (and Lynne sent a reply off-list 
approving the previous iteration, without the test reference updates), 
I'll go ahead an push this one soon.

// Martin