[FFmpeg-devel] [PATCH 1/7] [RFC] Revert "avcodec/adpcm_swf: support decoding multiple fixed-sized blocks at once"

[Zane van Iperen]

On 6/11/20 11:51 am, Zane van Iperen wrote:
> 
> 
> On 6/11/20 9:11 am, Michael Niedermayer wrote:
>> The reverted code split at block_align boundaries, but there was already code
>> which splits at a hardcoded 4096 sample boundary.
>>
>> reverting this seemed like the easiest fix but this is a RFC in case another solution
>> is preferred
>>
> 
> This breaks playback when adpcm_swf is used in WAVs. block_align needs to be respected
> otherwise everything is garbled.
> When coming from a SWF file, block_align isn't set so it reverts to the legacy behaviour.
> 
> See https://trac.ffmpeg.org/ticket/5829
> 
> 

Never mind, this behaviour is wrong. Turns out the encoder was producing invalid frames and this
simply covered-up the issue. Revert away!

I'll send out a fix for the encoder soon.