[FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

[Steven Liu]

> 2020年11月6日 下午4:42，Bohan Li <bohanli at google.com> 写道：
> 
> Thanks for the reply, Steven! 
> 
> Regarding JEEB’s comment, the suggestion was to add an api to the *libaom* library, not to ffmpeg. I do agree with the rationale, but when such an api would be available for ffmpeg to use is quite uncertain. In the meanwhile, I believe it is reasonable to add in this patch to expose the option to the users. I don’t think this is a “middle version”, since as mentioned, this option could be quite useful in certain scenarios and IMHO should be added in. 
What about use av1_param arguments? As x264opts, x265opts?
> 
> Please let me know if there are any concerns on this. Thanks!
> 
> Best,
> Bohan
> 
> On Thu, Nov 5, 2020 at 6:35 PM Steven Liu <lq at chinaffmpeg.org> wrote:
> 
> 
> > 2020年11月6日 上午2:29，Bohan Li <bohanli-at-google.com at ffmpeg.org> 写道：
> > 
> > Another ping :)
> I think maybe you should fix JEEB’s review comment, then will get responses comments.
> Not only apply a middle version.
> > 
> > Bohan
> > 
> > On Fri, Oct 30, 2020 at 2:43 PM Bohan Li <bohanli at google.com> wrote:
> > 
> >> Gentle ping :)
> >> 
> >> Bohan
> >> 
> >> On Tue, Oct 27, 2020 at 4:13 PM Bohan Li <bohanli at google.com> wrote:
> >> 
> >>> Hi Jan,
> >>> 
> >>> Thanks for the suggestion! I believe that is a good idea. I am not super
> >>> familiar with this part, though, so will probably need to propose this to
> >>> the Aomedia issue tracker.
> >>> Meanwhile I think it is also useful to expose useful options (like this
> >>> one, enable-keyframe-filtering, which is discussed quite a few times in the
> >>> community as far as I know) to the users as well. So I think we should
> >>> still apply this patch, and if once the mentioned API is working, we could
> >>> maybe re-consider which ones are more needed.
> >>> 
> >>> Best,
> >>> Bohan
> >>> 
> >>> On Tue, Oct 27, 2020 at 2:19 PM Jan Ekström <jeebjp at gmail.com> wrote:
> >>> 
> >>>> On Tue, Oct 27, 2020 at 10:38 PM Bohan Li
> >>>> <bohanli-at-google.com at ffmpeg.org> wrote:
> >>>>> 
> >>>>> Add the option to use -enable-keyframe-filtering with libaom-av1
> >>>>> codec.  The option controls the encoder behavior on performing
> >>>>> temporal filtering on keyframes.
> >>>>> 
> >>>> 
> >>>> Hi,
> >>>> 
> >>>> Looking at the amount of options etc which you want to expose to
> >>>> FFmpeg users (or just utilize yourselves via FFmpeg), and by the
> >>>> feeling that we're duplicating a lot of option parsing that aomenc CLI
> >>>> is already doing, I wonder if it would be more useful for libaom to
> >>>> provide a key=value API? This then could be exposed to FFmpeg users
> >>>> with an option similar to {x264,x265,rav1e}-params.
> >>>> 
> >>>> This way each time libaom adds new options, they don't explicitly need
> >>>> to be added to the wrapper. They can just be utilized.
> >>>> 
> >>>> Best regards,
> >>>> Jan
> >>>> _______________________________________________
> >>>> ffmpeg-devel mailing list
> >>>> ffmpeg-devel at ffmpeg.org
> >>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>>> 
> >>>> To unsubscribe, visit link above, or email
> >>>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> >>> 
> >>> 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> 
> Thanks
> 
> Steven Liu
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Thanks

Steven Liu