[FFmpeg-devel] [PATCH 5/5] avformat: add amv muxer

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Mon Nov 2 18:39:33 EET 2020


Zane van Iperen:
> On 2/11/20 7:47 pm, Andreas Rheinhardt wrote:
> 
>>> +    if (pkt->stream_index == AMV_STREAM_VIDEO) {
>>> +        /* Save the last packet for padding. */
>>> +        av_packet_unref(&amv->vpad);
>>> +        av_packet_ref(&amv->vpad, pkt);
>>
>> Missing check.
>>
> For what specifically? Afaics av_buffer_unref() (called from 
> av_packet_unref()) can handle a NULL buf.
> 
For av_packet_ref(): It can fail.

- Andreas


More information about the ffmpeg-devel mailing list