[FFmpeg-devel] [PATCH 2/4] avformat/concatdec: Check filename length before use

[Michael Niedermayer]

On Thu, Oct 29, 2020 at 04:22:23PM +0100, Andreas Rheinhardt wrote:
> Nicolas George:
> > Michael Niedermayer (12020-10-28):
> >> Fixes: out array read
> >> Fixes: 26610/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-5631838049271808
> >>
> >> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> >> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >> ---
> >>  libavformat/concatdec.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > This is not the first time such a fix is proposed. If strcmp() does not
> > behave intelligently, then we need an extra function for the task, but
> > duplicating the test all over the place is not a good idea.
> > 
> We already have av_strstart() which would also allow us to avoid
> computing strlen(proto) at all.

patch with av_strstart() posted, av_strstart() was available since
a long time so it should have no negative impact on backporting

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201101/5affc166/attachment.sig>