[FFmpeg-devel] [PATCH v6 1/1] avformat: add kvag muxer

Michael Niedermayer michael at niedermayer.cc
Sun May 31 01:22:27 EEST 2020


On Sat, May 30, 2020 at 12:10:14AM +0000, Zane van Iperen wrote:
> On Fri, 29 May 2020 23:41:46 +0200
> "Michael Niedermayer" <michael at niedermayer.cc> wrote:
> 
> > 
> > On Fri, May 29, 2020 at 10:54:59AM +0000, Zane van Iperen wrote:
> > > Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
> > > ---
> > >  Changelog                |  1 +
> > >  libavformat/Makefile     |  1 +
> > >  libavformat/allformats.c |  1 +
> > >  libavformat/kvag.c       | 82
> > > +++++++++++++++++++++++++++++++++++++++- libavformat/version.h    |
> > >  2 +- 5 files changed, 85 insertions(+), 2 deletions(-)
> > 
> > should the muxer not be in its own file ?
> > that would avoid #if*
> > 
> Normally, I'd agree. However, it's a very simple format and there's not
> actually that much code, so I think separate files is overkill for this.

ok, will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200531/55937ca4/attachment.sig>


More information about the ffmpeg-devel mailing list