[FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

Anton Khirnov anton at khirnov.net
Thu May 28 21:22:42 EEST 2020


Quoting Lynne (2020-05-28 18:26:44)
> May 28, 2020, 17:20 by michael at niedermayer.cc:
> 
> > TODO: Bump
> >
> >  */
> >  #define AV_CODEC_FLAG2_FAST           (1 <<  0)
> > +
> > +/**
> > + * Allow speedups tricks which can read out of array on non compliant streams.
> > + */
> > +#define AV_CODEC_FLAG2_FAST_UNSAFE    (1 <<  1)
> >
> 
> That's a bug. We should absolutely not have flags to enable bugs.
> The fast flag should be removed from h264 until that bug is fixed,
> or deprecated altogether.

+9001

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list