[FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

[Paul B Mahol]

On 5/28/20, Nicolas George <george at nsup.org> wrote:
> Paul B Mahol (12020-05-24):
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavfilter/avfilter.c | 61 +++++++++++++++++++++++++++++++++++++-----
>>  libavfilter/filters.h  | 17 ++++++++++++
>>  2 files changed, 72 insertions(+), 6 deletions(-)
>
> I am against this.
>
> It adds quite a lot of complexity in common code.
>
> This complexity is not needed: in patch 4/4, you always peek
> s->window_size samples and skip s->hop_size, constants: just allocate a
> permanent buffer with size s->window_size and roll by s->hop_size in it.
> It will be more efficient (less copying around, less allocations) and
> simpler.
>

Your arrogance means nothing to me.

Will apply in 5 minutes.