[FFmpeg-devel] [RFC/PATCH] avcodec: deprecate thread_safe_callbacks

[Lynne]

May 22, 2020, 15:04 by anton at khirnov.net:

> They add considerable complexity to frame-threading implementation,
> which includes an unavoidably leaking error path, while the advantages
> of this option to the users are highly dubious.
>
> It should be always possible and desirable for the callers to make their
> get_buffer2() implementation thread-safe, so deprecate this option.
> ---
> The patch is incomplete and not ready to be pushed, I am mainly
> gathering opinions. Is anyone aware of a valid use case for
> thread_safe_callbacks?
>

+1
mpv's get_buffer2 implementation is thread safe yet still doesn't signal its thread-safe due
to misunderstandings with the docs for no good reason.
API users have always had the option to make their implementation thread safe so I'm not
sure why this was even an option.