[FFmpeg-devel] [PATCH] avutil/video_enc_param: fix warning

Nicolas George george at nsup.org
Thu May 21 17:50:09 EEST 2020


lance.lmwang at gmail.com (12020-05-21):
> I'm not sure, Mac compile give below warning:
> 
>  warning: comparison of constant 922337203685477580 with expression of type 'unsigned int' is always false
>       [-Wtautological-constant-out-of-range-compare]
> 

Certainly. And?

> > The cast is unnecessary due to C's promotion rules.
> Yes, It seems it's not necessary as the first test.

The cast is unnecessary, period. Do you know C's promotion rules in this
case?

What I am really asking, in both cases, is:

Do you understand what you are doing?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200521/bfb9ead0/attachment.sig>


More information about the ffmpeg-devel mailing list