[FFmpeg-devel] [PATCH v3 2/2] avdevice/lavf: change the dumpgraph option to bool type

[Nicolas George]

lance.lmwang at gmail.com (12020-05-19):
> Thanks for sharing the background, now the document isn't very clear how to
> use the option, after checking, nobody use it, so I think it's better to 
> claim it as bool. I can take a look how to convert graph to dot format if nobody
> will support it.

Since nothing uses it yet, you are free to do what you want with it. But
if you just treat the options string as bool, you cannot use it to
select the output format.

If you intend to also implement the DOT output, then it is better to
really treat it like an options string, probably using
parse_key_value_pair() (why do we have two versions of this is beyond
me) or similar.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200519/7b7a6051/attachment.sig>