[FFmpeg-devel] [PATCH 6/6] avcodec: move mpeg4 profiles to profiles.h

[Marton Balint]

On Mon, 18 May 2020, Fu, Linjie wrote:

>> diff --git a/libavcodec/profiles.h b/libavcodec/profiles.h
>> index d950971875..e414ea77a7 100644
>> --- a/libavcodec/profiles.h
>> +++ b/libavcodec/profiles.h
>> @@ -37,6 +37,12 @@
>>      FF_AVCTX_PROFILE_OPTION("mpeg2_aac_low", NULL, AUDIO,
>> FF_PROFILE_MPEG2_AAC_LOW)\
>>      FF_AVCTX_PROFILE_OPTION("mpeg2_aac_he",  NULL, AUDIO,
>> FF_PROFILE_MPEG2_AAC_HE)\
>>
>> +#define FF_MPEG4_PROFILE_OPTS \
>> +    FF_AVCTX_PROFILE_OPTION("mpeg4_sp",      NULL, VIDEO,
>> FF_PROFILE_MPEG4_SIMPLE)\
>> +    FF_AVCTX_PROFILE_OPTION("mpeg4_core",    NULL, VIDEO,
>> FF_PROFILE_MPEG4_CORE)\
>> +    FF_AVCTX_PROFILE_OPTION("mpeg4_main",    NULL, VIDEO,
>> FF_PROFILE_MPEG4_MAIN)\
>> +    FF_AVCTX_PROFILE_OPTION("mpeg4_asp",     NULL, VIDEO,
>> FF_PROFILE_MPEG4_ADVANCED_SIMPLE)\
>> +
> Since it's now searchable according to the AVClass, we may not need
> the prefix anymore. (for now it's necessary for the ABI)
>
> Hence would it be better to add some deprecated flags for them and
> remove the prefix in future  when avcodec version increase?
> (something like FF_API_NEXT)

Yes, can be done later, but this patch is only about moving existing 
option names, not deprecating existing ones and adding new names.

Regards,
Marton