[FFmpeg-devel] [PATCH] avcodec: improve the function of FF_ALLOC{Z}{_ARRAY}_OR_GOTO

Marton Balint cus at passwd.hu
Tue May 12 21:22:17 EEST 2020



On Tue, 12 May 2020, Nicolas George wrote:

> Marton Balint (12020-05-12):
>> I think you want to force your preferred pattern to cases which clearly do
>> not benefit from it.
>
> I want to prevent any pattern where the error code is lost or invented.
> We already had enough work old cases where we were not careful enough
> with it, I oppose to anything that could give us more similar work.
>
> If you do not like my proposal, feel free to make counter-proposals, but
> if they pose the risk of losing the error code or let the caller invent
> it, I will oppose them.

Then I guess this patch got bikeshedded to pieces with no clear 
resolution. It was a cleanup attempt anyway, so I suggest the author to 
simply abandon it.

Regards,
Marton


More information about the ffmpeg-devel mailing list