[FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: Don't use heap allocated array to store pids

Marton Balint cus at passwd.hu
Tue May 12 11:37:14 EEST 2020



On Mon, 11 May 2020, Andriy Gelman wrote:

> On Fri, 01. May 17:54, Marton Balint wrote:
>> 
>> 
>> On Thu, 30 Apr 2020, Andriy Gelman wrote:
>> 
>> > From: Andriy Gelman <andriy.gelman at gmail.com>
>> > 
>> > A temporary heap array currently stores pids from all streams.  It is
>> > used to make sure there are no duplicated pids. However, this array is
>> > not needed because the pids from past streams are stored in the
>> > MpegTSWriteStream structs.
>> > 
>> 
>> LGTM, thanks.
>> 
>> Marton
>> 
>
> Hi Marton, 
>
> Thanks for the review.
> Is it ok to push both patches?

Sure, go ahead.

Thanks,
Marton


More information about the ffmpeg-devel mailing list