[FFmpeg-devel] [PATCH 1/3] closed caption decoder: accept and decode a new codec type of 'raw 608 byte pairs'

Anton Khirnov anton at khirnov.net
Thu May 7 15:32:36 EEST 2020


Quoting Roger Pack (2020-04-28 08:15:19)
> From 5d7c12a3f703e794e1092087355bc9523d5f4d93 Mon Sep 17 00:00:00 2001
> From: rogerdpack <rogerpack2005 at gmail.com>
> Date: Tue, 28 Apr 2020 05:15:15 +0000
> Subject: [PATCH 1/3] closed caption decoder: accept and decode a new codec
>  type of 'raw 608 byte pairs'
> 
> Signed-off-by: rogerdpack <rogerpack2005 at gmail.com>
> ---
> diff --git a/libavcodec/codec_id.h b/libavcodec/codec_id.h
> index e7d6e059db..805e18758b 100644
> --- a/libavcodec/codec_id.h
> +++ b/libavcodec/codec_id.h
> @@ -513,6 +513,7 @@ enum AVCodecID {
>  
>      AV_CODEC_ID_MICRODVD   = 0x17800,
>      AV_CODEC_ID_EIA_608,
> +    AV_CODEC_ID_EIA_608_RAW_BYTE_PAIRS,

You can't just add new IDs in the middle of the table, it changes the
IDs of all the following codecs which breaks ABI.
Add it to the end of the subtitle block.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list