[FFmpeg-devel] [PATCH 2/4] doc/examples/muxing.c: Fixed a compile warning

Nicolas George george at nsup.org
Sat May 2 15:39:06 EEST 2020


Zhao, Gang (12020-05-02):
> With the new api, function write_audio_frame and write_video_frame can be
> combined to one.
> Because there is already a local function called write_frame, I changed the
> name to muxing_write_frame
> to avoid name collision.

Multiple changes in the same patch make it harder to review. You could
name the merged function write_any_frame().

And if you think it is best, make another patch to rename both
functions: it would be easier to review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200502/896f782a/attachment.sig>


More information about the ffmpeg-devel mailing list