[FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

[Dale Curtis]

On Fri, May 1, 2020 at 2:00 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> Am Fr., 1. Mai 2020 um 22:16 Uhr schrieb Dale Curtis <
> dalecurtis at chromium.org>:
> >
> > On Fri, May 1, 2020 at 1:12 PM Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:
> >
> > > Am Fr., 1. Mai 2020 um 22:06 Uhr schrieb James Almer <
> jamrial at gmail.com>:
> > > > Just make the check
> > > >
> > > > (AV_GCC_VERSION_AT_LEAST(5,1) || defined(__clang__)) &&
> > > > !defined(__INTEL_COMPILER)
> > >
> > > And switch the conditions.
> >
> > Thanks. Done.
>
> Is there a reason why this doesn't use
> __has_builtin(__builtin_add_overflow)
> for clang?
>

Yes, prior to clang 10 it didn't work properly:
https://clang.llvm.org/docs/LanguageExtensions.html#has-builtin

- dale