[FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

James Almer jamrial at gmail.com
Fri May 1 23:06:14 EEST 2020


On 5/1/2020 4:50 PM, Dale Curtis wrote:
> On Fri, May 1, 2020 at 12:37 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 
>>>
>>> So ICC on Linux defines __GNUC__ >= 5 yet doesn't support these builtins?
>>
>> No, but yes, this is the effect.
>>
> 
> Does this patch work instead on the ICC compiler? GCC 4.2+ have support for
> __has_builtin() which shouldn't be masqueraded by the ICC.

Just make the check

(AV_GCC_VERSION_AT_LEAST(5,1) || defined(__clang__)) &&
!defined(__INTEL_COMPILER)

And yes, make it 5.1 since that's the first release. 5.0 was the
in-development version.

> 
> - dale
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> 



More information about the ffmpeg-devel mailing list