[FFmpeg-devel] [PATCH 1/2] avcodec/hapdec: Check tex_size more strictly and before using it

Michael Niedermayer michael at niedermayer.cc
Tue Mar 31 21:58:21 EEST 2020


On Tue, Mar 31, 2020 at 05:45:39PM +0200, Moritz Barsnick wrote:
> On Sat, Mar 28, 2020 at 22:12:45 +0100, Michael Niedermayer wrote:
> > +        if (ctx->tex_size != (avctx->coded_width  / TEXTURE_BLOCK_W)
> > +            *(avctx->coded_height / TEXTURE_BLOCK_H)
> > +            *tex_rat[t]) {
> 
> It would be easier to recognize that this is a multiplication and not a
> dereference, if the '*' wasn't attached to the right hand term.
> 
> But I do realize you only moved the block of code.

ill fix this together with another bug i found in this when i apply or
post a new version of this

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200331/ba117080/attachment.sig>


More information about the ffmpeg-devel mailing list