[FFmpeg-devel] [PATCH] avformat/movenc: stop guessing colr atom values

Derek Buitenhuis derek.buitenhuis at gmail.com
Tue Mar 31 15:23:12 EEST 2020


On 31/03/2020 00:25, Michael Bradshaw wrote:
> If this really breaks things for people (which I highly doubt it will) they
> can always send a patch with a better and more robust implementation. But I
> feel strongly that we should not stabilize the write_colr flag with this
> auto-guessing logic. We really shouldn't have people depend on it and
> should encourage them to use the -color_primaries/-color_trc/-colorspace
> flags themselves for better color guessing.

Also important to note that 'unspecified' are entirely valid values to be set by
the user of an encoding library, and changing them out under their feet is pretty
evil, in my opinion.

I agree strongly with Michael's points.

- Derek


More information about the ffmpeg-devel mailing list