[FFmpeg-devel] [PATCH 4/7] mpegvideo: use the AVVideoEncParams API for exporting QP tables

[Michael Niedermayer]

On Mon, Mar 30, 2020 at 01:45:23PM +0200, Anton Khirnov wrote:
> Do it only when requested with the AV_CODEC_EXPORT_DATA_VIDEO_ENC_PARAMS
> flag.
> 
> Drop previous code using the long-deprecated AV_FRAME_DATA_QP_TABLE*
> API.
> ---
>  libavcodec/h263dec.c         |  6 ++++--
>  libavcodec/mpeg12dec.c       |  5 +++--
>  libavcodec/mpegpicture.c     |  1 +
>  libavcodec/mpegpicture.h     |  1 +
>  libavcodec/mpegvideo.c       | 39 ++++++++++++++++++++++++++++--------
>  libavcodec/mpegvideo.h       |  8 +++++++-
>  libavcodec/rv10.c            |  5 +++--
>  libavcodec/rv34.c            |  5 +++--
>  libavutil/video_enc_params.h |  2 ++
>  9 files changed, 55 insertions(+), 17 deletions(-)

This seems to break fate-filter-pp
TEST    filter-pp
--- ./tests/ref/fate/filter-pp	2020-03-25 02:01:55.010219361 +0100
+++ tests/data/fate/filter-pp	2020-03-30 23:52:46.611521793 +0200
@@ -3,8 +3,8 @@
 #codec_id 0: rawvideo
 #dimensions 0: 352x288
 #sar 0: 1/1
-0,          1,          1,        1,   152064, 0x0af8a873
-0,          2,          2,        1,   152064, 0xaeb99897
-0,          3,          3,        1,   152064, 0x8f3712c8
-0,          4,          4,        1,   152064, 0x5bf6a64c
-0,          5,          5,        1,   152064, 0x262de352
+0,          1,          1,        1,   152064, 0x3588a88c
+0,          2,          2,        1,   152064, 0x91dd9897
+0,          3,          3,        1,   152064, 0xef9b12c2
+0,          4,          4,        1,   152064, 0x83a2a64f
+0,          5,          5,        1,   152064, 0xc4dae34e
Test filter-pp failed. Look at tests/data/fate/filter-pp.err for details.
tests/Makefile:250: recipe for target 'fate-filter-pp' failed
make: *** [fate-filter-pp] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200330/d4e59a97/attachment.sig>