[FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

Zane van Iperen zane at zanevaniperen.com
Sun Mar 29 14:18:45 EEST 2020


On Sun, 29 Mar 2020 01:49:32 +0100
"Carl Eugen Hoyos" <ceffmpeg at gmail.com> wrote:


> Apart from what I wrote on irc:
> What surprises me most is that iirc, you explained that the
> sample_rate is written repeatedly to the file and is always identical
> in one file. Why is that not checked?
> 

The main reason is that the track headers are spread out all over the
file, which will almost certainly be larger than the probe buffer.

The best I can do is check that the sample rate of the first track
matches that of the file (as it's immediately after the main header).
I do this in the next version of the patch, which I will be posting
later.

> You seem to have a fine (and small) collection of sample rates to
> check against.
> 
> Carl Eugen

Zane



More information about the ffmpeg-devel mailing list