[FFmpeg-devel] [PATCH 1/3] avformat/avformat: Update av_read_frame() documentation

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Sun Mar 29 05:54:35 EEST 2020


Andreas Rheinhardt:
> Anton Khirnov:
>> Quoting Andreas Rheinhardt (2019-12-01 11:05:44)
>>> This commit updates the documentation of av_read_frame() to match its
>>> actual behaviour in several ways:
>>>
>>> 1. On success, av_read_frame() always returns refcounted packets.
>>> 2. It can handle uninitialized packets.
>>> 3. On error, it always returns clean packets.
>>>
>>> This will allow callers to not initialize or unref unnecessarily.
>>>
>>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>>> ---
>>
>> Looks ok, don't know if the version bump is necessary since there is no
>> change in behaviour.
>>
> I don't feel to strongly about it either. What do others think of it? If
> there is no one in favour of it, I will remove it.
> 
> - Andreas
> 
Pushed without the version bump. Thanks.

- Andreas


More information about the ffmpeg-devel mailing list