[FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_mix: Check sscanf() return value

[Nicolas George]

Limin Wang (12020-03-29):
> If av_sscanf failed,  s->weights[i] is invalid data and can't be used
> further.

I think you are mistaken: if av_sscanf() fails, s->weights[i] stays
unchanged: it was 0, it's still 0.

> As the old code allow to use the last weights, so I use 
> continue to avoid invalid access only.

It's not invalid, it's 0.

> Do you think it's better to
> print out one warning message?

With this correction, I think this change is not necessary at all.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200329/f05e4676/attachment.sig>