[FFmpeg-devel] [PATCH 8/8] avformat/audiointerleave: only keep the retime functionality of the audio interleaver

Marton Balint cus at passwd.hu
Sun Mar 29 00:40:28 EET 2020



On Sat, 28 Mar 2020, James Almer wrote:

> On 3/28/2020 3:15 PM, Marton Balint wrote:
>> +static int mxf_check_bitstream(struct AVFormatContext *s, const AVPacket *pkt)
>> +{
>> +    int ret = 1;
>> +    AVStream *st = s->streams[pkt->stream_index];
>> +    MXFStreamContext *sc = st->priv_data;
>> +
>> +    if (st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO) {
>> +        char arg[32];
>> +        snprintf(arg, sizeof(arg), "r=%d/%d", sc->aic.time_base.den, sc->aic.time_base.num);
>> +        ret = ff_stream_add_bitstream_filter(st, "pcm_rechunk", arg);
>
> Shouldn't you check that the stream's codec is PCM?

Our MXF muxer only allows PCM streams at the moment, other codecs won't 
have a matching mxf_essence_mapping, so write_header will fail.

Regards,
Marton


More information about the ffmpeg-devel mailing list