[FFmpeg-devel] [PATCH 2/2] avcodec/hcadec: Check scale_factors

[Paul B Mahol]

LGTM

On 3/28/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
> Fixes: out of array read
> Fixes:
> 21286/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_fuzzer-5683183715876864
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/hcadec.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavcodec/hcadec.c b/libavcodec/hcadec.c
> index 4e3f589579..f25d6c39b6 100644
> --- a/libavcodec/hcadec.c
> +++ b/libavcodec/hcadec.c
> @@ -345,6 +345,7 @@ static void unpack(HCAContext *c, ChannelContext *ch,
>              } else {
>                  factor += delta - half_max;
>              }
> +            factor = av_clip_uintp2(factor, 6);
>
>              ch->scale_factors[i] = factor;
>          }
> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".