[FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

Nicolas George george at nsup.org
Sat Mar 28 13:54:14 EET 2020


Andreas Rheinhardt (12020-03-28):
> The commit title says that this commit is about fixing a memleak (it btw

That is my concern too.

> has one "commit" too much in it), whereas most of this patch is about
> adding new functionality. Which makes me wonder how you intend to fix
> this in the old releases? Backport everything?
> (This problem would of course not exist if the new functionality would
> be split from fixing the memleak.)

The leak exists in a release? Then it settles things: revert the
original commit, period.

Then, Steven, you can continue this very patch, you just need to rebase
it on top of the revert, it will actually be simpler.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200328/f7b4ac78/attachment.sig>


More information about the ffmpeg-devel mailing list