[FFmpeg-devel] [PATCH v2 1/2] libavcodec/jpeg2000dec.c: Add functions and modify structs for PPT marker support

[Gautam Ramakrishnan]

On Fri, Mar 27, 2020 at 10:59 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
> Am Fr., 27. März 2020 um 17:21 Uhr schrieb <gautamramk at gmail.com>:
> >
> > From: Gautam Ramakrishnan <gautamramk at gmail.com>
> >
> > This patch modifies the Jpeg2000Tile struct and breaks the
> > jpeg2000_decode_packet() function into two to decode packet
> > header and data separately.
>
> The solution is also not to add functions that are unused at first.
>
> I don't know if it is good to split the patch but you mentioned
> that you had to split a particular function. That makes it sound
> as if you should - with the first patch - split the function without
> changing FFmpeg's behaviour, and then with a second patch
> change FFmpeg's behaviour by adding the new functionality.
> As said, I don't know if that simplifies the review in this
> specific case.
I was not too sure what to do in this case. Thought that splitting it
in the first patch could show what new functions are present.
> Did you already look at the sample file I pointed out?
Yep, am going through the sample file. I shall try to see what
is causing those errors. However I am assuming that the errors
could be due to other bugs in the decoder or due to some
unimplemented features?
>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



-- 
-------------
Gautam |