[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec Support for PPT marker

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Mar 27 17:00:25 EET 2020


Am Fr., 27. März 2020 um 15:58 Uhr schrieb Gautam Ramakrishnan
<gautamramk at gmail.com>:

> I was a bit apprehensive about removing the jpeg2000_decode_packet()
> function. I had basically split that function into 2 separate ones.
> Should I keep it till we add more changes to the decoder or do I
> remove it now itself?

Not sure what the right solution is but there should be no (new)
compilation warning.

If you have split a function, then this should be a separate patch
that makes the reviews easier.
(First patch: Splitting a function without functional improvement,
second patch: Functional improvement)

Please find out what top-posting means and avoid it here.

Carl Eugen


More information about the ffmpeg-devel mailing list