[FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

Anton Khirnov anton at khirnov.net
Fri Mar 27 12:02:47 EET 2020


Quoting Moritz Barsnick (2020-03-24 09:47:14)
> On Sun, Mar 22, 2020 at 09:59:21 +0100, Steve Lhomme wrote:
> > Always use a comma at the end, order elements by value.
> 
> IIUC, this is strictly a C99(+) "feature", so should probably be
> mentioned here:
> https://ffmpeg.org/developer.html#C-language-features
> in case "all compilers we care about" support this.
> 
> (Yes, I am aware that many other enums in said file already are
> formatted thus.)
> 
> Deeply into nitpick country, ;-)

IMO we should stop picking specific C99 features we require and just
say we assume all of it, except some forbidden features (VLA, complex
numbers). We even borderline-depend on a C11 feature (atomics).

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list