[FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

Jan Ekström jeebjp at gmail.com
Sat Mar 21 13:47:21 EET 2020


On Fri, Mar 20, 2020 at 3:31 PM Paul B Mahol <onemda at gmail.com> wrote:
>
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---

I am not sure how well I'd be able to review the technicalities, and
thus I only have the following requests:
- Since I didn't see a mention of the current limitations of this
implementation (such as the lack of deblocking that you mentioned on
IRC), please at the very least mention that in the commit message.
- Is it possible to get a FATE test for this, or would you like
someone else do generate such? If you would like someone else to
generate the reference for you, do you know of any nice wrapper on top
of the RAD Bink2 DLLs to dump YCbCr reference pictures so our
comparison would be against the reference?

Best regards,
Jan


More information about the ffmpeg-devel mailing list