[FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak for commit commit e134c203

[Nicolas George]

Steven Liu (12020-03-20):
> Why the specification add these attributes into the documents if these attributes not useful, just kidding?
> I said I’m not the specification author.

What Anton and I are trying to explain to you is that either your code
handles the attributes according to the specification, with actual
technical consequences, or your code is useless.

Getting the attribute, parsing it, getting it into a variable, carrying
this variable around, and doing nothing with that variable is a waste of
effort.

For example, adaptionset_lang reaches the metadata dictionary, and is
therefore available for the application: it's useful.

On the other hand, adaptionset_minwidth is just stored in a variable and
does nothing: get rid of if.

Maybe later you'll come to implement something that uses
adaptionset_minwidth: since you already wrote the code, you can commit
all of it together.

In short: don't build half a bridge, either build the whole bridge or
keep the materials for later.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200320/084293c1/attachment.sig>