[FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak for commit commit e134c203

[Anton Khirnov]

Quoting Steven Liu (2020-03-19 00:30:52)
> 
> Thanks
> 
> Steven Liu
> 
> > 2020年3月19日 上午12:48，Andreas Rheinhardt <andreas.rheinhardt at gmail.com> 写道：
> > 
> > Hello,
> > 
> > before the actual review I want to tell you that I actually agree with
> > Nicholas. I don't see the point of already parsing stuff that is not
> > used yet, especially if it involves allocations and checks.
> 
> Yes, I agreed with all of you, but I think we should try to "full
> support all the attributes parse" what writes in the sepcification,
> And try to use all the attribute. Because those attribute in the
> specification is not useless and have some reason, I’m not member of
> the specification author,

You seem to be contradicting yourself. Either you agree that it is
pointless to parse attributes that do not get used, in which case you
shouldn't send patches that do precisely that.
Or you believe that we should in fact parse things that do not get used,
then you do not agree with the other commenters. Both at once are not
possible.

FWIW I believe that the entire point of demuxers is to export useful
data to the caller. Therefore any code that does not contribute towards
that goal is useless and should not be present in the tree.

-- 
Anton Khirnov