[FFmpeg-devel] [PATCH 13/18] h264_sei: parse the picture timing SEIs correctly
Anton Khirnov
anton at khirnov.net
Mon Mar 16 21:50:54 EET 2020
Quoting James Almer (2020-03-16 20:42:31)
> On 3/16/2020 3:51 PM, Michael Niedermayer wrote:
> > On Fri, Mar 13, 2020 at 11:28:45AM +0100, Anton Khirnov wrote:
> >> Those SEIs refer to the currently active SPS. However, since the SEI
> >> NALUs precede the coded picture data in the bitstream, the active SPS is
> >> in general not known when we are decoding the SEI.
> >>
> >> Therefore, store the content of the picture timing SEIs and actually
> >> parse it when the active SPS is known.
> >> ---
> >> libavcodec/h264_parser.c | 9 +++++
> >> libavcodec/h264_sei.c | 86 ++++++++++++++++++++++++----------------
> >> libavcodec/h264_sei.h | 11 +++++
> >> libavcodec/h264_slice.c | 10 +++++
> >> 4 files changed, 82 insertions(+), 34 deletions(-)
> >
> > This seems to break fate
> >
> > TEST cbs-h264-CVSE2_Sony_B
> > --- ./tests/ref/fate/cbs-h264-CVSE2_Sony_B 2020-03-15 16:08:13.692521532 +0100
> > +++ tests/data/fate/cbs-h264-CVSE2_Sony_B 2020-03-16 19:50:23.164302663 +0100
> > @@ -1 +0,0 @@
> > -ca8bdba497bd2f3b97c50d59692eb537
> > Test cbs-h264-CVSE2_Sony_B failed. Look at tests/data/fate/cbs-h264-CVSE2_Sony_B.err for details.
> > tests/Makefile:250: recipe for target 'fate-cbs-h264-CVSE2_Sony_B' failed
> > make: *** [fate-cbs-h264-CVSE2_Sony_B] Error 1
> >
> > thx
>
> I can't reproduce this. Are you using a clean tree?
Yeah, me neither. I ran FATE on the tree before sending it.
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list