[FFmpeg-devel] [PATCH 1/3] ffmpeg: explicitly handle sub2video subpicture initialization

[Jan Ekström]

On Thu, Mar 12, 2020 at 1:42 AM Jan Ekström <jeebjp at gmail.com> wrote:
>
> Each time the sub2video structure is initialized, the sub2video
> subpicture is initialized together with the first received heartbeat.
> The heartbeat's PTS is utilized as the subpicture start time.
>
> Additionally, add some documentation on the stages.
> ---
>  fftools/ffmpeg.c        | 22 +++++++++++++++-------
>  fftools/ffmpeg.h        |  3 ++-
>  fftools/ffmpeg_filter.c |  8 +++++++-
>  3 files changed, 24 insertions(+), 9 deletions(-)
>

This patch was originally posted on Feb 26, 2019. It was then pinged
3rd of March, 2019
(https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190226001220.27888-1-jeebjp@gmail.com/).
I decided then to not push it in due to lack of tests for the exact
case which Michael mentioned.

Thus while I anyone is free to review this and I would be much obliged
for such, now that:
- this thing has FATE tests at least making sure that anything which
touches the results of those would be noticed (and then either the
tests or the code gets adjusted depending on which is correct)
- the PGS subtitle sample was uploaded yesterday into the FATE system.

I would like to start pushing this set in during tomorrow, barring
anyone finding issues with the code until then.

Best regards,
Jan