[FFmpeg-devel] [PATCH v3 7/7] avformat/audiointerleave: use a fixed frame duration for non-audio packets

[Tomas Härdin]

fre 2020-03-13 klockan 02:31 +0100 skrev Marton Balint:
> The packet durations might not be set properly which can cause the MXF muxer
> to write more than one packet of a stream to an edit unit messing up the
> constant byte per element index...

Shouldn't this be fixed "higher up"?

> Also warn the user if the incoming DTS is not increasing by frame duration
> because in that case A-V sync issues can occur because of the DTS rewriting.

I'm not a huge fan of this, shouldn't we investigate why this happens
instead? DTS being non-monotonic is a big deal

> Also use nb_samples directly to calculate dts of audio packets because adding
> packet durations might not be precise.

lavf is such a mess...

The patch itself looks fine, modulo the above concerns

/Tomas