[FFmpeg-devel] [PATCH 08/17] avformat/webm_chunk: Use appropriate initializer for AV_OPT_TYPE_STRING

Moritz Barsnick barsnick at gmx.net
Wed Mar 4 11:49:37 EET 2020


On Mon, Mar 02, 2020 at 05:44:36 +0100, Andreas Rheinhardt wrote:
> -    { "header", "filename of the header where the initialization data will be written", OFFSET(header_filename), AV_OPT_TYPE_STRING, { 0 }, 0, 0, AV_OPT_FLAG_ENCODING_PARAM },
> +    { "header", "filename of the header where the initialization data will be written", OFFSET(header_filename), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, AV_OPT_FLAG_ENCODING_PARAM },

I found some 19 or so further occurences of this pattern[*]. Are they
worth "fixing", or is it a purely cosmetic thing?

[*] $ find -name "*.[ch]" -print0 | xargs -0 grep -Pn 'AV_OPT_TYPE_STRING,\s*{\s*0\s*}'

Cheers,
Moritz


More information about the ffmpeg-devel mailing list