[FFmpeg-devel] [PATCH] ffmpeg: remove superfluous custom cuvid hwaccel

[Timo Rothenpieler]

On 03.03.2020 18:00, James Almer wrote:
> It's apparently not working, and is a duplicate of the properly implemented
> nvdec libavcodec hwaccel.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> When i try decoding a sample using -hwaccel cuvid I get
> 
> [h264 @ 000001ab70730020] decoder->cvdl->cuvidCreateDecoder(&decoder->decoder, params) failed -> CUDA_ERROR_INVALID_VALUE: invalid argument
> [h264 @ 000001ab70730020] Failed setup for format cuda: hwaccel initialisation returned error
> 
> That same sample works just fine if i instead use -hwaccel nvdec. And seeing this
> hwaccel is merely a ffmpeg.c specific implementation using AVHWFramesContext, much
> like the libavcodec hwaccel, i figured it was best to just remove it and map cuvid
> to nvdec in order to not break existing cli scripts.
> 
> The same can probably be done with the VideoToolbox one, but not the QSV as there's
> no such hwaccel in libavcodec (One should probably be written).

It should be working fine still, but there's really no reason to keep it.