[FFmpeg-devel] [PATCH 1/1] Patch for adding Documentation of ff_http_match_no_proxy

[Sourabh Sharma]

Patch for adding Documentation of ff_http_match_no_proxy
Function ff_http_match_no_proxy check for host of proxy address matches with
 the hostname or not.

---
 libavformat/network.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/libavformat/network.h b/libavformat/network.h
index 71347e815b..7c93375ae5 100644
--- a/libavformat/network.h
+++ b/libavformat/network.h
@@ -303,6 +303,13 @@ int ff_listen_connect(int fd, const struct sockaddr *addr,
                       socklen_t addrlen, int timeout,
                       URLContext *h, int will_try_next);

+/**
+ * It Checks for a host of proxy address matches with the hostname or not.
+ *
+ * @param no_proxy Server address of proxy server e.g. example.domain.com
+ * @param hostname Server address of hostname e.g. domain.com
+ * @return         0 if don't match, 1 for exactly match
+*/
 int ff_http_match_no_proxy(const char *no_proxy, const char *hostname);

 int ff_socket(int domain, int type, int protocol);
-- 
2.11.0


On Sun, Mar 1, 2020 at 2:49 AM Michael Niedermayer <michaelni at gmx.at> wrote:

> On Sat, Feb 29, 2020 at 05:07:30PM +0530, Sourabh Sharma wrote:
> > Patch for adding Documentation of ff_http_match_no_proxy
> >
> > Function ff_http_match_no_proxy check for host of proxy address
> > matches with hostname or not.
> > ---
> >  libavformat/network.h | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/network.h b/libavformat/network.h
> > index 71347e815b..cd533a7cbc 100644
> > --- a/libavformat/network.h
> > +++ b/libavformat/network.h
> > @@ -302,7 +302,13 @@ int ff_accept(int fd, int timeout, URLContext *h);
> >  int ff_listen_connect(int fd, const struct sockaddr *addr,
> >                        socklen_t addrlen, int timeout,
> >                        URLContext *h, int will_try_next);
> > -
>
> > +/**
> > + * It Check for host of proxy address matches with hostname or not.
>
> This has some english grammer issues.
> Also look at how other similar function doxy is worded
>
>
> > + *
> > + * @param no_proxy URL of proxy address
> > + * @param hostname URL of hostname
>
> I dont think the function would be understood from just this
>
>
> thx
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Does the universe only have a finite lifespan? No, its going to go on
> forever, its just that you wont like living in it. -- Hiranya Peiri
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".