[FFmpeg-devel] [PATCH 2/2] libavfilter/vf_colorconstancy.c : Adding weighted greyedge

[Moritz Barsnick]

On Thu, Jun 18, 2020 at 19:22:56 +0530, Yatendra Singh wrote:
> +    for(int h = slice_start; h < slice_end; h++)
> +    {

Space between "for" and "(", and the opening bracket '{' goes on the
same line.

> +        for(int w = 0; w < width; w++)
> +        {

Same here, and elsewhere (also for "if" and "while").

> +                norm_temp   = pow( td->data[INDEX_DX][plane][INDX2D(h,w,width)], 2);
> +                norm_temp   += pow( td->data[INDEX_DY][plane][INDX2D(h,w,width)], 2);
> +                norm        += sqrt( norm_temp);

No space after the function calls' opening brackets.

> +    .description   = NULL_IF_CONFIG_SMALL("Estimates scene illumination by grey edge assumption."),

Imperative: "Estimate".

Moritz