[FFmpeg-devel] [PATCH v2] lavf/movenc: Use a dynamic buffer when writing the mfra box

Derek Buitenhuis derek.buitenhuis at gmail.com
Sun Jun 28 15:25:01 EEST 2020


On 26/06/2020 13:58, Derek Buitenhuis wrote:
> When doing streamed output, with e.g. +dash, if the mfra box ended
> up being larger than the AVIOContext write buffer, the (unchecked)
> seeking back to update the box size would silently fail and produce
> an invalid mfra box.
> 
> This is similar to how other boxes are written in fragmented mode.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
> It is still weird to me that we prefer all of our internal code
> to use ffio_free_dyn_buf but don't allow actual public API users
> to use this functionality.
> ---
>  libavformat/movenc.c | 38 ++++++++++++++++++++++++++------------
>  1 file changed, 26 insertions(+), 12 deletions(-)

Will push tonight barring any objections.

- Derek


More information about the ffmpeg-devel mailing list