[FFmpeg-devel] [FFmpeg-cvslog] avcodec/mpeg12dec: switch to AVBufferRef buffer for a53 caption

[lance.lmwang at gmail.com]

On Sat, Jun 27, 2020 at 02:48:50PM +0300, Martin Storsjö wrote:
> On Sat, 27 Jun 2020, lance.lmwang at gmail.com wrote:
> 
> > On Sat, Jun 27, 2020 at 10:37:31AM +0200, Paul B Mahol wrote:
> > > On 6/27/20, lance.lmwang at gmail.com <lance.lmwang at gmail.com> wrote:
> > > > On Sat, Jun 27, 2020 at 10:22:24AM +0200, Paul B Mahol wrote:
> > > >> On 6/27/20, lance.lmwang at gmail.com <lance.lmwang at gmail.com> wrote:
> > > >> > On Sat, Jun 27, 2020 at 09:47:33AM +0300, Martin Storsjö wrote:
> > > >> >> On Fri, 26 Jun 2020, Limin Wang wrote:
> > > >> >>
> > > >> >> > ffmpeg | branch: master | Limin Wang <lance.lmwang at gmail.com> | Sun
> > > >> >> > Jun
> > > >> >> > 21 20:57:22 2020 +0800| [a705bcd763e344fac191e157ffeddc285388b7fa] |
> > > >> >> > committer: Limin Wang
> > > >> >> >
> > > >> >> > avcodec/mpeg12dec: switch to AVBufferRef buffer for a53 caption
> > > >> >> >
> > > >> >> > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > > >> >> >
> > > >> >> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a705bcd763e344fac191e157ffeddc285388b7fa
> > > >> >> > ---
> > > >> >>
> > > >> >>
> > > >> >> This commit caused use of uninitialized data in fate-sub-cc-scte20,
> > > >> >> making
> > > >> >> the test nondeterministic.
> > > >> >
> > > >> > Sorry, how to reproduce the issue? I'm glad to check the issue. Before
> > > >> > submit the patch,
> > > >> > I have run and pass make fate testing.
> > > >> > On my testing x86_64 linux host and mac pro, I have run:
> > > >> >
> > > >> > make  fate-sub-cc-scte20  SAMPLES=../fate-suite
> > > >> >
> > > >> > no error report yet.
> > > >> >
> > > >>
> > > >> You will need to use valgrind.
> > > >
> > > > thanks, I have no experiment to use fate test with valgrind yet, I'll try to
> > > > study how to use it.
> > > 
> > > Just run same commands fate runs but under valgrind.
> > 
> > Thanks for the help, I have run with valgrind before, but haven't see
> > any error yet.
> > 
> > [lmwang at vpn2 ffmpeg.git]$ valgrind make fate-sub-cc-scte20  SAMPLES=../fate-suite --leak-check=full
> 
> That just runs the make process in valgrind, not the test itself.
> 
> Try this: make V=1 fate-sub-cc-scte20 TARGET_EXEC="valgrind --error-exitcode=1"

thanks, it's reproduced by the command line. I'll submit the patch to fix it.

> 
> // Martin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang