[FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

lance.lmwang at gmail.com lance.lmwang at gmail.com
Fri Jun 26 14:08:08 EEST 2020


On Fri, Jun 26, 2020 at 12:50:40PM +0200, Nicolas George wrote:
> lance.lmwang at gmail.com (12020-06-26):
> > Yes, It make sense. Now there are ERROR, INFO, WARNING. Can we change all of the
> > to INFO? If can't, then we'll had to remove the end \n and add for every case.
> 
> Absolutely not. ERRORs need to be visible even if INFO is hidden.
> 
> Personally, I consider that the messages at different log levels are
> just completely separate, and should not be interleaved within a single
> line. I can accept tidbits of VERBOSE within a line of INFO, but that's
> the maximum.
> 
> In this case, that means the ERROR message needs to be complete, and the
> INFO needs to be consistent even if there is an error.

OK, I'll submit a patch to add extra \n for ERROR and WARNING message. I 
think it's OK to print one extra INFO \n if it's info level.

> 
> Regards,
> 
> -- 
>   Nicolas George



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


-- 
Thanks,
Limin Wang


More information about the ffmpeg-devel mailing list