[FFmpeg-devel] [PATCH v4 1/7] FATE: add h264 timecode side data test

[lance.lmwang at gmail.com]

On Wed, Jun 24, 2020 at 09:43:14PM +0800, lance.lmwang at gmail.com wrote:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> The old fate test is for framecrc and haven't testing timecode info.
> so it's better to change to ffprobe and dump them.
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  tests/fate/h264.mak          |    4 +-
>  tests/ref/fate/h264-timecode | 3608 ++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 3305 insertions(+), 307 deletions(-)
> 
> diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak
> index 13a596e..0bf6800 100644
> --- a/tests/fate/h264.mak
> +++ b/tests/fate/h264.mak
> @@ -196,7 +196,6 @@ FATE_H264  := $(FATE_H264:%=fate-h264-conformance-%)                    \
>                fate-h264-3386                                            \
>                fate-h264-missing-frame                                   \
>                fate-h264-ref-pic-mod-overflow                            \
> -              fate-h264-timecode                                        \
>                fate-h264-encparams
>  
>  FATE_H264-$(call DEMDEC, H264, H264) += $(FATE_H264)
> @@ -228,6 +227,7 @@ FATE_H264-$(call DEMDEC, MXF, H264) += fate-h264-xavc-4389
>  FATE_H264-$(call DEMDEC, MOV, H264) += fate-h264-attachment-631
>  FATE_H264-$(call DEMDEC, MPEGTS, H264) += fate-h264-skip-nokey fate-h264-skip-nointra
>  FATE_H264_FFPROBE-$(call DEMDEC, MATROSKA, H264) += fate-h264-dts_5frames
> +FATE_H264_FFPROBE-$(call DEMDEC, H264, H264) += fate-h264-timecode
>  
>  FATE_SAMPLES_AVCONV += $(FATE_H264-yes)
>  FATE_SAMPLES_FFPROBE += $(FATE_H264_FFPROBE-yes)
> @@ -442,7 +442,7 @@ fate-h264-twofields-packet:                       CMD = framecrc -i $(TARGET_SAM
>  fate-h264-unescaped-extradata:                    CMD = framecrc -i $(TARGET_SAMPLES)/h264/unescaped_extradata.mp4 -an -frames 10
>  fate-h264-3386:                                   CMD = framecrc -i $(TARGET_SAMPLES)/h264/bbc2.sample.h264
>  fate-h264-missing-frame:                          CMD = framecrc -i $(TARGET_SAMPLES)/h264/nondeterministic_cut.h264
> -fate-h264-timecode:                               CMD = framecrc -i $(TARGET_SAMPLES)/h264/crew_cif_timecode-2.h264
> +fate-h264-timecode:                               CMD = probeframes -show_entries frame=side_data -select_streams v -i $(TARGET_SAMPLES)/h264/crew_cif_timecode-2.h264
Note for the fate testing:

I'm trying to use less frames(2-4s) data for fate testing, but the read_intervals option isn't
working for the raw h264 file by the actual testing.
./ffprobe -show_entries frame=side_data  -read_intervals "%2s" -select_streams v ../fate-suite/h264/crew_cif_timecode-2.h264  |wc -l
2402
./ffprobe -show_entries frame=side_data  -read_intervals "%4s" -select_streams v ../fate-suite/h264/crew_cif_timecode-2.h264  |wc -l
2402

So the patch fate testing is only show no broken for the side data after
change.

>  
>  fate-h264-reinit-%:                               CMD = framecrc -i $(TARGET_SAMPLES)/h264/$(@:fate-h264-%=%).h264 -vf format=yuv444p10le,scale=w=352:h=288
>