[FFmpeg-devel] [PATCH 1/6] avutil/opt: check return value of av_bprint_finalize()

[lance.lmwang at gmail.com]

On Wed, Jun 24, 2020 at 05:36:08PM +0200, Nicolas George wrote:
> lance.lmwang at gmail.com (12020-06-22):
> > From: Limin Wang <lance.lmwang at gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > ---
> >  libavutil/opt.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/libavutil/opt.c b/libavutil/opt.c
> > index 2c3f998..552985e 100644
> > --- a/libavutil/opt.c
> > +++ b/libavutil/opt.c
> > @@ -2120,6 +2120,9 @@ int av_opt_serialize(void *obj, int opt_flags, int flags, char **buffer,
> >              av_freep(&buf);
> >          }
> >      }
> > -    av_bprint_finalize(&bprint, buffer);
> > +    ret = av_bprint_finalize(&bprint, buffer);
> > +    if (ret < 0)
> > +        return ret;
> > +
> >      return 0;
> >  }
> 
> The extra empty line seems unnecessary. LGTM otherwise.

Thanks, fix locally. will apply tomorrow if no comments from other developer.

> 
> Regards,
> 
> -- 
>   Nicolas George



-- 
Thanks,
Limin Wang