[FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

Andriy Gelman andriy.gelman at gmail.com
Mon Jun 22 17:55:56 EEST 2020


On Mon, 22. Jun 09:58, Valery Kot wrote:
> On Mon, Jun 22, 2020 at 7:58 AM Andriy Gelman <andriy.gelman at gmail.com> wrote:
> >
> > Hi Valery,
> >
> > Thanks for the patch.
> >
> > Please also update the fate test:
> > https://patchwork.ffmpeg.org/project/ffmpeg/patch/CAGTf1MnCX2JOO-VMTUCDKjCP76y5JsLnhubzat4MF48c2hfd6g@mail.gmail.com/
> 
> Thanks for feedback. Updating FATE tests is a bridge too far for me. I
> can't even build FFmpeg itself at the moment, say nothing about
> setting up the test environment and finding out how it works. Could
> you please do this update for me?

It should be enough to change the hashes in two files.
Please resend with these changes.

diff --git a/tests/ref/fate/filter-edgedetect b/tests/ref/fate/filter-edgedetect
index 23c9953e61..e49639afac 100644
--- a/tests/ref/fate/filter-edgedetect
+++ b/tests/ref/fate/filter-edgedetect
@@ -1 +1 @@
-edgedetect          93ceace33f6636bcdbeb037317c65745
+edgedetect          04ff46bb35edff3dbad4102391516d25
diff --git a/tests/ref/fate/filter-edgedetect-colormix b/tests/ref/fate/filter-edgedetect-colormix
index e828c6bd19..0df17344bc 100644
--- a/tests/ref/fate/filter-edgedetect-colormix
+++ b/tests/ref/fate/filter-edgedetect-colormix
@@ -1 +1 @@
-edgedetect-colormix 1b8658252e2f03fbae30e6d63dd24c7c
+edgedetect-colormix 9f50c5586f899a8f5a10059154d64bde


Thanks,
-- 
Andriy


More information about the ffmpeg-devel mailing list